Changeset fa75134 for account.c

Timestamp:

2008-04-01T23:07:21Z (16 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

4af7b4f, 5be87b2, 5f5d433, 69aaf14, 883a398, dd34575, f1e7407

Parents:

ddba0ae

Message:

Reordered irc_free() a little bit, hoping that this will fix a crash-on-quit
bug I can't figure out. The previous order wasn't optimal.

File:

• account.c (modified) (2 diffs)

account.c

@@ -182 +182 @@
         account_t *a, *l = NULL;
         
+        if( acc->ic )
+                /* Caller should have checked, accounts still in use can't be deleted. */
+                return;
+        
         for( a = irc->accounts; a; a = (l=a)->next )
                 if( a == acc )
                 {
-                        if( a->ic ) return; /* Caller should have checked, accounts still in use can't be deleted. */
-                        
                         if( l )
-                        {
                                 l->next = a->next;
-                        }
                         else
-                        {
                                 irc->accounts = a->next;
-                        }
                         
                         while( a->set )
@@ -203 +201 @@
                         g_free( a->user );
                         g_free( a->pass );
-                        if( a->server ) g_free( a->server );
+                        g_free( a->server );
                         if( a->reconnect )      /* This prevents any reconnect still queued to happen */
                                 cancel_auto_reconnect( a );