Changeset 090f1cb for protocols/jabber/xmltree.c

Timestamp:

2006-10-07T13:01:02Z (18 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

36e9f62

Parents:

101d84f

Message:

Never mind about those privacy lists, they're horrible and not supported
by any client I know of. Also, they're already working on a (probably
completely incompatible) standard: JEP-191. Maybe BitlBee will implement
it too some day...

File:

• protocols/jabber/xmltree.c (modified) (1 diff)

protocols/jabber/xmltree.c

@@ -528 +528 @@
         int i;
         
-        for( i = 0; node->attr[i].key; i ++ );
-        node->attr = g_renew( struct xt_attr, node->attr, i + 2 );
-        node->attr[i].key = g_strdup( key );
+        /* Now actually it'd be nice if we can also change existing attributes
+           (which actually means this function doesn't have the right name).
+           So let's find out if we have this attribute already... */
+        for( i = 0; node->attr[i].key; i ++ )
+                if( strcmp( node->attr[i].key, key ) == 0 )
+                        break;
+        
+        if( node->attr[i].key == NULL )
+        {
+                /* If not, allocate space for a new attribute. */
+                node->attr = g_renew( struct xt_attr, node->attr, i + 2 );
+                node->attr[i].key = g_strdup( key );
+                node->attr[i+1].key = NULL;
+        }
+        else
+        {
+                /* Otherwise, free the old value before setting the new one. */
+                g_free( node->attr[i].value );
+        }
+        
         node->attr[i].value = g_strdup( value );
-        node->attr[i+1].key = NULL;
-}
+}