Changeset e6f47fb for help.c


Ignore:
Timestamp:
2015-03-04T23:01:39Z (5 years ago)
Author:
dequis <dx@…>
Branches:
master
Children:
8b91a1f
Parents:
56985aa
git-author:
dequis <dx@…> (04-03-15 05:13:58)
git-committer:
dequis <dx@…> (04-03-15 23:01:39)
Message:

help: Increase read buffer size from 1100 to 2048

This fixes "Error opening helpfile." that was introduced by the rawreply
commit, which made the help string for "help set commands" larger than
1100 bytes, making the strstr(s, "\n%\n") condition fail

I have absolutely no idea why it was 1100 to begin with. It's been like
that since the first revision. 2048 is arbitrary too, but it's nicer.

Needless to say, the help.c code needs to be reviewed more deeply, at
least. Could also use that opportunity to get rid of the xmlto/xslt crap.
Not going to do that right now, i don't want to add more bugs.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • help.c

    r56985aa re6f47fb  
    3030#undef write
    3131
    32 #define BUFSIZE 1100
     32#define BUFSIZE 2048
    3333
    3434help_t *help_init(help_t **help, const char *helpfile)
Note: See TracChangeset for help on using the changeset viewer.