Changeset bbff22d for protocols/twitter/twitter.c

Timestamp:

2015-10-09T02:41:01Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

b87e5dc

Parents:

c4e61db

git-author:

dequis <dx@…> (08-10-15 07:48:06)

git-committer:

dequis <dx@…> (09-10-15 02:41:01)

Message:

twitter: Fix some nitpicky issues reported by coverity

Mostly minor rare leaks that happen in error conditions, and one
dereference before null check in twitter_logout (the null check is
probably the wrong one there, but it doesn't hurt to keep it)

File:

• protocols/twitter/twitter.c (modified) (1 diff)

protocols/twitter/twitter.c

@@ -678 +678 @@
         ic->flags &= ~OPT_LOGGED_IN;
 
-        // Remove the main_loop function from the function queue.
-        b_event_remove(td->main_loop_id);
-
-        if (td->timeline_gc) {
-                imcb_chat_free(td->timeline_gc);
-        }
-
         if (td) {
+                // Remove the main_loop function from the function queue.
+                b_event_remove(td->main_loop_id);
+
+                if (td->timeline_gc) {
+                        imcb_chat_free(td->timeline_gc);
+                }
+
                 if (td->filter_update_id > 0) {
                         b_event_remove(td->filter_update_id);