Changeset bb34771

Timestamp:

2010-03-14T16:35:55Z (14 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

caceb06

Parents:

286b28e

Message:

Close fd's 0,1,2 no matter what, not just if they're ttys. (Bug #476)

File:

• bitlbee.c (modified) (1 diff)

bitlbee.c

@@ -109 +109 @@
                 chdir( "/" );
                 
-                /* Sometimes std* are already closed (for example when we're in a RESTARTed
-                   BitlBee process. So let's only close TTY-fds. */
-                if( isatty( 0 ) ) close( 0 );
-                if( isatty( 1 ) ) close( 1 );
-                if( isatty( 2 ) ) close( 2 );
+                i = close( 0 ) == 0;
+                i += close( 1 ) == 0;
+                i += close( 2 ) == 0;
+                /* To avoid that something important ends up on one of those
+                   fd's, open them for something bogus. Otherwise RESTART
+                   may cause troubles. */
+                while( i > 0 )
+                {
+                        open( "/dev/null", O_WRONLY );
+                        i --;
+                }
         }
 #endif