Changeset b4f496e for root_commands.c

Timestamp:

2016-11-19T07:32:48Z (7 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

a7baf40

Parents:

9f03c47

Message:

Improve handling of unknown protocols / missing plugins

Instead of failing to load the config, a fake prpl is created to load
the account, keep its settings, and refuse to log in with a helpful
error message.

Also added a new explain_unknown_protocol() function which returns text
which attempts to explain why a protocol is missing, handling several
typical cases, including the future removal of several dead libpurple
plugins.

That message is shown when logging in to a loaded account with a missing
protocol and when adding a new one with 'account add', with the
difference that the latter doesn't leave a placeholder fake account.

File:

• root_commands.c (modified) (1 diff)

root_commands.c

@@ -439 +439 @@
 
                 if (prpl == NULL) {
-                        if (is_protocol_disabled(cmd[2])) {
-                                irc_rootmsg(irc, "Protocol disabled in global config");
-                        } else {
-                                irc_rootmsg(irc, "Unknown protocol");
-                        }
+                        char *msg = explain_unknown_protocol(cmd[2]);
+                        irc_rootmsg(irc, "Unknown protocol");
+                        irc_rootmsg(irc, msg);
+                        g_free(msg);
                         return;
                 }