Changeset b38d399 for lib/base64.h

Timestamp:

2014-11-24T05:16:09Z (8 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

9f8bb17

Parents:

e2472dd

Message:

Use glib functions for base64 decoding/encoding

This fixes several coverity warnings about 'tainted data index sink' and
a fixme about thread safety in the old base64_decode implementation.

Had to adapt the code that used base64_encode_real:

• oauth.c: different character set order, but it's for the nonce so it doesn't matter
• libyahoo2.c: used as part of the auth, changes "+/=" into "._-". Fixed by encoding first the usual way through glib, then replacing.

File:

• lib/base64.h (modified) (1 diff)

lib/base64.h

@@ -28 +28 @@
 G_MODULE_EXPORT char *tobase64( const char *text );
 G_MODULE_EXPORT char *base64_encode( const unsigned char *in, int len );
-G_MODULE_EXPORT int base64_encode_real( const unsigned char *in, int inlen, unsigned char *out, const char *b64digits );
 G_MODULE_EXPORT char *frombase64( const char *in );
 G_MODULE_EXPORT int base64_decode( const char *in, unsigned char **out );
-G_MODULE_EXPORT int base64_decode_real( const unsigned char *in, unsigned char *out, char *b64reverse );