Changeset 6b13103 for lib/misc.c

Timestamp:

2015-01-16T19:50:23Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

1065dd4, eabe6d4

Parents:

6f10697

Message:

Replace isdigit/isalpha/.../tolower/toupper with glib variants

This fixes warnings about passing signed chars to them (apparently they
are implemented as macros that do array lookups without checks in some
platforms, yay)

Specifically:

functions=isalnum|isalpha|isdigit|isspace|isxdigit|tolower|toupper
sed -ir "s/$functions/g_ascii_&/g" /*.c

File:

• lib/misc.c (modified) (4 diffs)

lib/misc.c

@@ -163 +163 @@
         while( *in )
         {
-                if( *in == '<' && ( isalpha( *(in+1) ) || *(in+1) == '/' ) )
+                if( *in == '<' && ( g_ascii_isalpha( *(in+1) ) || *(in+1) == '/' ) )
                 {
                         /* If in points at a < and in+1 points at a letter or a slash, this is probably
@@ -198 +198 @@
                 {
                         cs = ++in;
-                        while( *in && isalpha( *in ) )
+                        while( *in && g_ascii_isalpha( *in ) )
                                 in ++;
                         
@@ -314 +314 @@
         for( i = j = 0; t[i]; i ++, j ++ )
         {
-                /* Warning: isalnum() is locale-aware, so don't use it here! */
+                /* Warning: g_ascii_isalnum() is locale-aware, so don't use it here! */
                 if( ( t[i] >= 'A' && t[i] <= 'Z' ) ||
                     ( t[i] >= 'a' && t[i] <= 'z' ) ||
@@ -490 +490 @@
         
         while( *value )
-                if( !isdigit( *value ) )
+                if( !g_ascii_isdigit( *value ) )
                         return 0;
                 else