Changes in / [27b407f:6197702]

Files:

• irc_user.c (modified) (1 diff)
• lib/ssl_gnutls.c (modified) (2 diffs)
• lib/xmltree.c (modified) (1 diff)
• protocols/msn/msn.c (modified) (1 diff)
• protocols/msn/ns.c (modified) (1 diff)
• protocols/msn/soap.c (modified) (5 diffs)

irc_user.c

@@ -157 +157 @@
         if( iu->fullname == NULL ) iu->fullname = g_strdup( iu->nick );
         
+        g_free( iu->key );
         iu->key = g_strdup( key );
         g_hash_table_insert( irc->nick_user_hash, iu->key, iu );

lib/ssl_gnutls.c

@@ -194 +194 @@
                 ssl_errno = SSL_AGAIN;
         
-        if( 0 && getenv( "BITLBEE_DEBUG" ) && st > 0 ) write( 1, buf, st );
+        if( 0 && getenv( "BITLBEE_DEBUG" ) && st > 0 ) len = write( 1, buf, st );
         
         return st;
@@ -215 +215 @@
                 ssl_errno = SSL_AGAIN;
         
-        if( 0 && getenv( "BITLBEE_DEBUG" ) && st > 0 ) write( 1, buf, st );
+        if( 0 && getenv( "BITLBEE_DEBUG" ) && st > 0 ) len = write( 1, buf, st );
         
         return st;

lib/xmltree.c

@@ -615 +615 @@
 void xt_insert_child( struct xt_node *parent, struct xt_node *child )
 {
-        struct xt_node *node, *last;
+        struct xt_node *node, *last = NULL;
+        
+        if( child == NULL )
+                return; /* BUG */
         
         for( node = child; node; node = node->next )

protocols/msn/msn.c

@@ -346 +346 @@
 {
         struct msn_data *md = bu->ic->proto_data;
+        struct msn_buddy_data *bd = bu->data;
+        
+        g_free( bd->cid );
+        g_free( bd );
+        
         g_tree_remove( md->domaintree, bu->handle );
-        g_free( bu->data );
 }
 

protocols/msn/ns.c

@@ -828 +828 @@
         
         adls = xt_to_string( adl );
+        xt_free_node( adl );
         msn_ns_write( ic, -1, "ADL %d %zd\r\n%s", ++md->trId, strlen( adls ), adls );
         g_free( adls );

protocols/msn/soap.c

@@ -210 +210 @@
 {
         char *s;
+        int st;
         
         if( !getenv( "BITLBEE_DEBUG" ) )
@@ -215 +216 @@
         
         if( ( s = strstr( headers, "\r\n\r\n" ) ) )
-                write( 1, s, s - headers + 4 );
+                st = write( 1, s, s - headers + 4 );
         else
-                write( 1, headers, strlen( headers ) );
+                st = write( 1, headers, strlen( headers ) );
         
 #ifdef DEBUG
@@ -283 +284 @@
         
         strncpy( pass, ic->acc->pass, MAX_PASSPORT_PWLEN );
+        pass[MAX_PASSPORT_PWLEN] = '\0';
         soap_req->payload = g_markup_printf_escaped( SOAP_PASSPORT_SSO_PAYLOAD,
                 ic->acc->user, pass, md->pp_policy );
@@ -440 +442 @@
         g_free( sd->error );
         g_free( sd->redirect );
+        g_free( sd );
         
         return MSN_SOAP_OK;
@@ -527 +530 @@
         else if( soap_req->http_req->status_code == 200 )
         {
+                /* Noise..
                 imcb_log( soap_req->ic, "Offline message successfully delivered to %s", oim->to );
+                */
                 return MSN_SOAP_OK;
         }
         else
         {
-                imcb_log( soap_req->ic, "Failed to deliver offline message to %s:\n%s", oim->to, oim->msg );
+                char *dec = frombase64( oim->msg );
+                imcb_log( soap_req->ic, "Failed to deliver offline message to %s:\n%s", oim->to, dec );
+                g_free( dec );
                 return MSN_SOAP_ABORT;
         }