Changeset 5c90890 for irc_im.c


Ignore:
Timestamp:
2018-07-12T08:54:12Z (3 years ago)
Author:
dequis <dx@…>
Branches:
master
Children:
c82e4ca
Parents:
b9d1fdc
git-author:
dequis <dx@…> (03-07-18 06:17:17)
git-committer:
dequis <dx@…> (12-07-18 08:54:12)
Message:

Stop using the irc->users linked list, use the hash table instead

irc_user_new() mentions that the reason this list is kept is for easy
iteration. Luckily, this is the future, and GHashTableIter exists now.

The main point of this is to get rid of the g_slist_insert_sorted() in
irc_user_set_nick() which is a particularly slow part of loading large
user lists, and scales poorly

In a test with discord, the GUILD_SYNC event is now 4 times faster, on
top of the improvements of the other bee_user hash tables patch.
Combining both patches it went from 136 to 6 seconds for 50k members.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • irc_im.c

    rb9d1fdc r5c90890  
    181181        }
    182182        if (iu == NULL) {
    183                 for (l = irc->users; l; l = l->next) {
    184                         iu = l->data;
     183                GHashTableIter iter;
     184                gpointer itervalue;
     185                g_hash_table_iter_init(&iter, irc->nick_user_hash);
     186
     187                while (g_hash_table_iter_next(&iter, NULL, &itervalue)) {
     188                        iu = itervalue;
    185189                        if (iu->bu) {
    186                                 bee_irc_channel_update(irc, ic, l->data);
     190                                bee_irc_channel_update(irc, ic, iu);
    187191                        }
    188192                }
Note: See TracChangeset for help on using the changeset viewer.