Changeset 5c90890 for irc.c


Ignore:
Timestamp:
2018-07-12T08:54:12Z (3 years ago)
Author:
dequis <dx@…>
Branches:
master
Children:
c82e4ca
Parents:
b9d1fdc
git-author:
dequis <dx@…> (03-07-18 06:17:17)
git-committer:
dequis <dx@…> (12-07-18 08:54:12)
Message:

Stop using the irc->users linked list, use the hash table instead

irc_user_new() mentions that the reason this list is kept is for easy
iteration. Luckily, this is the future, and GHashTableIter exists now.

The main point of this is to get rid of the g_slist_insert_sorted() in
irc_user_set_nick() which is a particularly slow part of loading large
user lists, and scales poorly

In a test with discord, the GUILD_SYNC event is now 4 times faster, on
top of the improvements of the other bee_user hash tables patch.
Combining both patches it went from 136 to 6 seconds for 50k members.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • irc.c

    rb9d1fdc r5c90890  
    242242{
    243243        GSList *l;
     244        GHashTableIter iter;
     245        gpointer itervalue;
    244246
    245247        irc->status |= USTATUS_SHUTDOWN;
     
    271273        bee_free(irc->b);
    272274
    273         while (irc->users) {
    274                 irc_user_free(irc, (irc_user_t *) irc->users->data);
     275        g_hash_table_iter_init(&iter, irc->nick_user_hash);
     276
     277        while (g_hash_table_iter_next(&iter, NULL, &itervalue)) {
     278                g_hash_table_iter_remove(&iter);
     279                irc_user_free(irc, (irc_user_t *) itervalue);
    275280        }
    276281
     
    292297        irc->fd = -1;
    293298
    294         g_hash_table_foreach_remove(irc->nick_user_hash, irc_free_hashkey, NULL);
    295299        g_hash_table_destroy(irc->nick_user_hash);
    296300
Note: See TracChangeset for help on using the changeset viewer.