Changeset 58b63de6 for irc_cap.c

Timestamp:

2015-10-08T08:34:18Z (8 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

c788e15

Parents:

2f73692

git-author:

dequis <dx@…> (11-09-15 22:07:10)

git-committer:

dequis <dx@…> (08-10-15 08:34:18)

Message:

IRCv3 SASL capability + PLAIN method

Only plain, no other methods. We don't have built-in SSL to implement
EXTERNAL (certfp) and nothing else is worth implementing.

The actual authentication is pretty much like sending a server password
(when the server's authmode isn't closed), which means it happens in
cmd_identify, but this code also calls storage_check_pass() to send the
required success/failure replies.

SASL doesn't give us much benefit other than standards compliance, but
some clients might appreciate it.

And having a fifth way to do the same thing doesn't hurt! Now we have:

• identify in &bitlbee
• identify to nickserv (alias for root)
• 'nickserv' and 'ns' irc commands
• server password
• sasl plain

File:

• irc_cap.c (modified) (2 diffs)

irc_cap.c

@@ -38 +38 @@
 
 static const cap_info_t supported_caps[] = {
+        {"sasl", CAP_SASL},
         {"multi-prefix", CAP_MULTI_PREFIX},
         {NULL},
@@ -170 +171 @@
         } else if (g_strcasecmp(cmd[1], "END") == 0) {
                 irc->status &= ~USTATUS_CAP_PENDING;
+
+                if (irc->status & USTATUS_SASL_PLAIN_PENDING) {
+                        irc_send_num(irc, 906, ":SASL authentication aborted");
+                        irc->status &= ~USTATUS_SASL_PLAIN_PENDING;
+                }
+
                 irc_check_login(irc);