Changeset 37437f2


Ignore:
Timestamp:
2018-08-26T21:17:06Z (4 months ago)
Author:
dequis <dx@…>
Branches:
master
Children:
5eab9260
Parents:
61fc056
git-author:
dequis <dx@…> (26-08-18 21:08:17)
git-committer:
dequis <dx@…> (26-08-18 21:17:06)
Message:

otr: Don't block attempts to connect/smp/smpq to "offline" users

Other otr implementations don't have this check, and in many modern IM
protocols the offline status isn't a reliable indicator of message
deliverability.

Given how this applies to explicit connection attempts, it's better to
just let these go through and assume the user knows what they are doing.
The worst that can happen here is some slight disappointment.

Change suggested by arc, thanks!

File:
1 edited

Legend:

Unmodified
Added
Removed
  • otr.c

    r61fc056 r37437f2  
    10571057        if (!u || !u->bu || !u->bu->ic) {
    10581058                irc_rootmsg(irc, "%s: unknown user", args[1]);
    1059                 return;
    1060         }
    1061         if (!(u->bu->flags & BEE_USER_ONLINE)) {
    1062                 irc_rootmsg(irc, "%s is offline", args[1]);
    10631059                return;
    10641060        }
     
    14371433                return;
    14381434        }
    1439         if (!(u->bu->flags & BEE_USER_ONLINE)) {
    1440                 irc_rootmsg(irc, "%s is offline", nick);
    1441                 return;
    1442         }
    14431435
    14441436        ctx = otrl_context_find(irc->otr->us, u->bu->handle,
Note: See TracChangeset for help on using the changeset viewer.