Changeset 329f9fe

Timestamp:

2014-02-02T00:31:49Z (10 years ago)

Author:

unknown <pesco@…>

Branches:

master

Children:

71004a3

Parents:

367ea3c

Message:

use OTRL_INSTAG_BEST instead of _RECENT to work around a segfault in libotr

File:

• otr.c (modified) (2 diffs)

otr.c

@@ -444 +444 @@
         irc_t *irc = iu->irc;
         struct im_connection *ic = iu->bu->ic;
-        otrl_instag_t instag = OTRL_INSTAG_RECENT; // XXX?
+        otrl_instag_t instag = OTRL_INSTAG_BEST; // XXX?
+        /* NB: in libotr 4.0.0 OTRL_INSTAG_RECENT will cause a null-pointer deref
+         * in otrl_message_sending with newly-added OTR contexts.
+         */
 
         /* don't do OTR on certain (not classic IM) protocols, e.g. twitter */
@@ -1345 +1348 @@
         irc_user_t *u;
         ConnContext *ctx;
-        otrl_instag_t instag = OTRL_INSTAG_RECENT;  // XXX
+        otrl_instag_t instag = OTRL_INSTAG_BEST;  // XXX
 
         u = irc_user_by_name(irc, nick);