Changeset 3183c21 for irc.c

Timestamp:

2008-09-06T22:59:32Z (16 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

15d1469

Parents:

0a4f6f4

Message:

Completely reviewed all uses of irc->password, irc_setpass() and
USTATUS_IDENTIFIED after another account overwriting vulnerability was
found by Tero Marttila.

File:

• irc.c (modified) (2 diffs)

irc.c

@@ -38 +38 @@
         irc_t *irc = set->data;
         
-        if( irc->status & USTATUS_IDENTIFIED )
+        if( irc->status & USTATUS_IDENTIFIED && value )
         {
                 irc_setpass( irc, value );
@@ -239 +239 @@
         
         if( irc->status & USTATUS_IDENTIFIED && set_getbool( &irc->set, "save_on_quit" ) ) 
-                if( storage_save( irc, TRUE ) != STORAGE_OK )
+                if( storage_save( irc, NULL, TRUE ) != STORAGE_OK )
                         irc_usermsg( irc, "Error while saving settings!" );