Changeset 241f9f6 for protocols/yahoo/libyahoo2.c

Timestamp:

2010-08-22T13:31:53Z (14 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

1aa74f55

Parents:

1bb1e01

Message:

Better handling of yahoo add responses: libyahoo2 seems to (IMHO) wrongly
assume that a non-0 status means the contact is on the list already and
on-line. This causes ugly "imcb_buddy_status() for unknown handle" msgs.

File:

• protocols/yahoo/libyahoo2.c (modified) (2 diffs)

protocols/yahoo/libyahoo2.c

@@ -2169 +2169 @@
         yd->buddies = y_list_append(yd->buddies, bud);
 
+#if 0
+        /* BitlBee: This seems to be wrong in my experience. I think:
+           status = 0: Success
+           status = 2: Already on list
+           status = 3: Doesn't exist
+           status = 42: Invalid handle (possibly banned/reserved, I get it for
+                        handles like joe or jjjjjj)
+           Haven't seen others yet. But whenever the add is successful, there
+           will be a separate "went online" packet when the auth. request is
+           accepted. Couldn't find any test account that doesn't require auth.
+           unfortunately (if there is even such a thing?) */
+           
         /* A non-zero status (i've seen 2) seems to mean the buddy is already 
          * added and is online */
@@ -2176 +2188 @@
                 YAHOO_CALLBACK(ext_yahoo_status_changed) (yd->client_id, who,
                         YAHOO_STATUS_AVAILABLE, NULL, 0, 0, 0);
+        }
+#endif
+        /* BitlBee: Need ACK of added buddy, if it was successful. */
+        if (status == 0) {
+                YList *tmp = y_list_append(NULL, bud);
+                YAHOO_CALLBACK(ext_yahoo_got_buddies) (yd->client_id, tmp);
+                y_list_free(tmp);
         }
 }