Changeset 199fea6

Timestamp:

2011-12-26T18:17:51Z (12 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

f1849a8

Parents:

5f40da7

Message:

Fixing memory leak in Twitter module.

File:

• protocols/twitter/twitter_lib.c (modified) (4 diffs)

protocols/twitter/twitter_lib.c

@@ -4 +4 @@
 *  Simple module to facilitate twitter functionality.                       *
 *                                                                           *
-*  Copyright 2009 Geert Mulders <g.c.w.m.mulders@gmail.com>                 *
+*  Copyright 2009-2010 Geert Mulders <g.c.w.m.mulders@gmail.com>            *
+*  Copyright 2010-2011 Wilmer van der Gaast <wilmer@gaast.net>              *
 *                                                                           *
 *  This library is free software; you can redistribute it and/or            *
@@ -786 +787 @@
         g_slist_free(output);
 
-        if (home_timeline && home_timeline->list) {
-                txl_free(home_timeline);
-        }
-
-        if (mentions && mentions->list) {
-                txl_free(mentions);
-        }
+        txl_free(home_timeline);
+        txl_free(mentions);
 
         td->flags &= ~(TWITTER_DOING_TIMELINE | TWITTER_GOT_TIMELINE | TWITTER_GOT_MENTIONS);
+        td->home_timeline_obj = td->mentions_obj = NULL;
 }
 
@@ -804 +801 @@
         struct twitter_data *td = ic->proto_data;
 
+        txl_free(td->home_timeline_obj);
         td->home_timeline_obj = NULL;
         td->flags &= ~TWITTER_GOT_TIMELINE;
@@ -839 +837 @@
         struct twitter_data *td = ic->proto_data;
 
+        txl_free(td->mentions_obj);
         td->mentions_obj = NULL;
         td->flags &= ~TWITTER_GOT_MENTIONS;