Changeset 0fbda193 for help.c

Timestamp:

2008-02-02T21:48:09Z (15 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

979cfb4

Parents:

f774e01

Message:

Added help_free() and cleaned up some very stale help-related stuff I
wasn't even aware of. This closes bug #352.

File:

• help.c (modified) (4 diffs)

help.c

@@ -71 +71 @@
                 {
                         /* FIXME: Clean up */
-//                      help_close( *help );
-                        *help = NULL;
+                        help_free( help );
                         g_free( s );
-                        return( NULL );
+                        return NULL;
                 }
                 i = strchr( s, '\n' ) - s;
                 
-                if( h->string )
+                if( h->title )
                 {
                         h = h->next = g_new0( help_t, 1 );
                 }
-                h->string = g_new ( char, i );
+                h->title = g_new ( char, i );
                 
-                strncpy( h->string, s + 1, i - 1 );
-                h->string[i-1] = 0;
+                strncpy( h->title, s + 1, i - 1 );
+                h->title[i-1] = 0;
                 h->fd = (*help)->fd;
                 h->offset.file_offset = lseek( h->fd, 0, SEEK_CUR ) - buflen + i + 1;
@@ -103 +102 @@
 }
 
-char *help_get( help_t **help, char *string )
+void help_free( help_t **help )
+{
+        help_t *h, *oh;
+        int last_fd = -1; /* Weak de-dupe */
+        
+        if( help == NULL || *help == NULL )
+                return;
+        
+        h = *help;
+        while( h )
+        {
+                if( h->fd != last_fd )
+                {
+                        close( h->fd );
+                        last_fd = h->fd;
+                }
+                g_free( h->title );
+                h = (oh=h)->next;
+                g_free( oh );
+        }
+        
+        *help = NULL;
+}
+
+char *help_get( help_t **help, char *title )
 {
         time_t mtime;
@@ -111 +134 @@
         for( h = *help; h; h = h->next )
         {
-                if( h->string != NULL && 
-                        g_strcasecmp( h->string, string ) == 0 ) 
+                if( h->title != NULL && g_strcasecmp( h->title, title ) == 0 )
                         break;
         }
@@ -119 +141 @@
                 char *s = g_new( char, h->length + 1 );
                 
-                if( fstat( h->fd, stat ) != 0 )
-                {
-                        g_free( h );
-                        *help = NULL;
-                        return NULL;
-                }
-                mtime = stat->st_mtime;
-                
-                if( mtime > h->mtime )
-                        return NULL;
-                
                 s[h->length] = 0;
                 if( h->fd >= 0 )
                 {
+                        if( fstat( h->fd, stat ) != 0 )
+                        {
+                                g_free( s );
+                                return NULL;
+                        }
+                        mtime = stat->st_mtime;
+                
+                        if( mtime > h->mtime )
+                        {
+                                g_free( s );
+                                return NULL;
+                        }
+                        
                         lseek( h->fd, h->offset.file_offset, SEEK_SET );
                         read( h->fd, s, h->length );