Changeset 05816dd for ipc.c

Timestamp:

2015-02-22T22:44:40Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

570f183

Parents:

91f06e5

git-author:

dequis <dx@…> (22-02-15 22:04:08)

git-committer:

dequis <dx@…> (22-02-15 22:44:40)

Message:

coverity: Fix some (harmless?) use-after-free with g_slist_remove()

These were passing a pointer to a variable right after it was g_free()'d

They are most likely harmless as g_slist_remove() probably just needs
the pointer location, but fixing it anyway.

File:

• ipc.c (modified) (2 diffs)

ipc.c

@@ -776 +776 @@
         }
 
+        child_list = g_slist_remove(child_list, c);
+
         g_free(c->host);
         g_free(c->nick);
@@ -781 +783 @@
         g_free(c->password);
         g_free(c);
-
-        child_list = g_slist_remove(child_list, c);
 
         /* Also, if any child has a reference to this one, remove it. */