Changeset dd89a55

Timestamp:

2006-05-15T17:57:12Z (18 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

10a0abf

Parents:

764b0aba

Message:

Fixed various memory leaks/other possible problems after code review.

Files:

• conf.c (modified) (1 diff)
• ipc.c (modified) (1 diff)
• irc.c (modified) (1 diff)
• protocols/nogaim.c (modified) (1 diff)
• protocols/oscar/service.c (modified) (2 diffs)
• set.c (modified) (1 diff)

conf.c

@@ -95 +95 @@
                         conf->port = i;
                 }
-                else if( opt == 'p' )
+                else if( opt == 'P' )
                 {
                         g_free( conf->pidfile );

ipc.c

@@ -571 +571 @@
         ipc_to_children_str( "OPERMSG :New BitlBee master process started (version " BITLBEE_VERSION ")\r\n" );
         
+        fclose( fp );
         return 1;
 }

irc.c

@@ -557 +557 @@
         
         u = user_find( irc, irc->mynick );
-        if( u ) is_private = u->is_private;
+        is_private = u->is_private;
         
         va_start( params, format );

protocols/nogaim.c

@@ -612 +612 @@
                         return;
                 }
-                return;
+                /* Why did we have this here....
+                return; */
         }
         

protocols/oscar/service.c

@@ -881 +881 @@
 #endif
 
+/* len can't be 0 here anyway...
                 } else if ((offset == 0x00001000) && (len == 0x00000000)) {
 
@@ -887 +888 @@
                         aimbs_put32(&fr->data, 0xe9800998);
                         aimbs_put32(&fr->data, 0xecf8427e);
-
+*/
                 } else
                         do_error_dialog(sess->aux_data, "WARNING: unknown hash request", "Gaim");

set.c

@@ -150 +150 @@
         if( s )
         {
-                t->next = s->next;
+                if( t )
+                        t->next = s->next;
+                else
+                        irc->set = s->next;
+                
                 g_free( s->key );
                 if( s->value ) g_free( s->value );