Changeset b0ee720 for lib

Timestamp:

2012-12-02T16:32:59Z (11 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

3bda2c2

Parents:

b3eee9b

Message:

Error handling fix in xmltree. Fixes a problem where if the start of the
stream is spread over two packets (or SSL records in this case), xt_handle()
would report a fatal error (which normally means the connection has failed
and should be abandoned immediately).

Returning 1 is likely more correct; just the fact that there's no data to
process yet is not a fatal failure.

This fixes potential issues with Google Talk when using OpenSSL (which
seems to be feeding data on record boundaries, even if additional records
have already been received).

File:

• lib/xmltree.c (modified) (1 diff)

lib/xmltree.c

@@ -163 +163 @@
         int i;
         
-        /* Just in case someone likes infinite loops... */
         if( xt->root == NULL )
-                return 0;
+                return 1;
         
         if( node == NULL )