Modify

Ticket #648 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Using Twitter and Identica accounts with the same username

Reported by: kensanata Owned by:
Priority: normal Milestone:
Component: BitlBee Version: Unlisted == unsupported.
Keywords: ui-fix twitter identica username Cc:
IRC client+version: Client-independent Operating System: Linux
OS version/distro:

Description

I use kensanata on Twitter and kensanata on Identica. I managed to set up both accounts, using chat mode, and everything seems to work. The only strange thing is that my Identica stuff ends up in #twitter_kensanata and my Twitter stuff ends up in #chat_000.

I'm using the ui-fix branch.

Attachments

kensanata.diff (2.7 KB) - added by alex@… 4 years ago.
A proposed patch to the bug. Author: Alex Schroeder <alex@…>
kensanata.2.diff (3.3 KB) - added by Alex Schroeder <kensanata@…> 4 years ago.
twitter.com uses twitter, identi.ca stays identi.ca
kensanata.3.diff (5.3 KB) - added by Alex Schroeder <kensanata@…> 4 years ago.
Now with a separate identica protocol; docs are still missing
kensanata.4.diff (4.2 KB) - added by Alex Schroeder <kensanata@…> 4 years ago.
suggested changes to the documentation

Change History

Changed 4 years ago by alex@…

A proposed patch to the bug. Author: Alex Schroeder <alex@…>

comment:1 follow-up: ↓ 2 Changed 4 years ago by wilmer

Thanks for the patch!

One thing that I find a bit unfortunate here is that the default name will also change. In most cases people will just be using Twitter, so #twitter_$username should be enough. It'd be nice to chop off the TLD, but with identi.ca that's not perfect either... :-(

comment:2 in reply to: ↑ 1 Changed 4 years ago by Alex Schroeder <alex@…>

Replying to wilmer:

One thing that I find a bit unfortunate here is that the default name will also change. In most cases people will just be using Twitter, so #twitter_$username should be enough. It'd be nice to chop off the TLD, but with identi.ca that's not perfect either... :-(

How about using the hostname, but strip off .com if that's what it ends in.

comment:3 Changed 4 years ago by wilmer

That may work, yeah. :-)

BTW, what about simply adding a room_name setting? Sorry for coming up with this at this point, but I've had complaints from people that the current name's too long. Having a setting like this would solve both problems.

Also, since Identi.ca is a fairly popular Twitter-compatible service, we can make the Twitter module register an "identica" service, besides Twitter itself, and give it different defaults for base_url, oauth and the channel name setting.

BTW, changing the username shouldn't be necessary since you can just use the rename command to set the nick to something sane.

comment:4 Changed 4 years ago by Alex Schroeder <kensanata@…>

Hm, not sure about the room_name setting. Yet another setting to change before it all works? I think my current patch does what is necessary. Having a room name setting in addition to that would be nice to have, but is no longer strictly necessary.

Having the Twitter module register an identica service with appropriate defaults would be awesome, but is a bit beyond my original goal. :)

Changed 4 years ago by Alex Schroeder <kensanata@…>

twitter.com uses twitter, identi.ca stays identi.ca

Changed 4 years ago by Alex Schroeder <kensanata@…>

Now with a separate identica protocol; docs are still missing

comment:5 Changed 4 years ago by Alex Schroeder <kensanata@…>

Ok, so adding a separate identica protocol was easier than I thought. :)

If you like it, I guess I'll write the docs as well. Just let me know...

comment:6 Changed 4 years ago by wilmer

Yeah, I told ya it's easy! :-)

Looks good, just a little bit code duplication that could be avoided. First, you can use something like memcpy() to copy the Twitter prpl struct, change a few fields and register.

Also, you can have one twitter_init() that checks prpl->name to figure out the right defaults for oauth and base_url? Unless you have a strong preference for your current approach..

comment:7 Changed 4 years ago by Alex Schroeder <kensanata@…>

I have no strong preferences. I'll take a look at memcpy and the suggested rewrite. I'm away over the week-end so perhaps this'll get delayed. Feel free to just take it and make any changes you want. :)

comment:8 Changed 4 years ago by wilmer

  • Status changed from new to closed
  • Resolution set to fixed

Alright, I made a few changes and submitted changeset:wilmer-ui-fix,720. Thanks!

Changed 4 years ago by Alex Schroeder <kensanata@…>

suggested changes to the documentation

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.