Ticket #325 (new enhancement)

Opened 3 years ago

Last modified 2 years ago

MSN groupchats don't show who invited you

Reported by: toxik Owned by: wilmer
Priority: normal Milestone:
Component: MSN Version: devel
Keywords: patch msn groupchats invited inviter Cc:
IRC client+version: Client-independent Operating System: Public server
OS version/distro:

Description

The MSN groupchats don't show who invited you into the groupchat, which is widely thought to be the first who was reported in an IRO command, sent from the switchboard server.

Attached patch solves this by adding the address-to-nickname mapped nickname to the topic, and if there's none, it just shows the e-mail address.

Attachments

bitlbee-msn_groupchat_inviter_topic-toxik.diff Download (1.3 KB) - added by toxik 3 years ago.
bitlbee-msn_groupchat_inviter_topic-toxik.diff
bitlbee-msn_groupchat_inviter_topic-r2-toxik.diff Download (0.9 KB) - added by toxik 3 years ago.
Revision 2: Removed layering abuse, dropped nice functionality.

Change History

Changed 3 years ago by toxik

bitlbee-msn_groupchat_inviter_topic-toxik.diff

Changed 3 years ago by toxik

After a brief discussion, we've concluded that the patch violates the oh-so-nice layering of bitlbee's API, so this isn't ever going into mainline.

A clean way of implementing it is still in progress.

Changed 3 years ago by toxik

Revision 2: Removed layering abuse, dropped nice functionality.

Changed 3 years ago by toxik

Also note my findings as of recently.

Sometimes the switchboard server will send you the IRO list in alphabetical order, and thence this patch will tell you somebody else invited you. Bottom line is that there's no way of knowing at all times.

Changed 3 years ago by wilmer

Hmm, if this is unreliable I'd rather not import it.

BTW, I thought the initial RNG message on the switchboard already mentions the remote user?

Add/Change #325 (MSN groupchats don't show who invited you)

Author


E-mail address and user name can be saved in the Preferences.


Action
as new
 
Note: See TracTickets for help on using tickets.